chore: Describe RBAC rules, remove unnecessary rules#767
Merged
NickLarsenNZ merged 13 commits intomainfrom Mar 27, 2026
Merged
Conversation
16 tasks
They were a bit too verbose
- Add missing description - Remove `get`, it is never used - Make list/watch unconditional
This was never needed, and if an end-user does happen to need their code reading secrets/configmaps, they should create the applicable role and binding.
Member
Author
|
NickLarsenNZ
commented
Mar 27, 2026
Techassi
reviewed
Mar 27, 2026
Member
There was a problem hiding this comment.
It all looks reasonable and the tests confirm it works. There is always the possibility we are not covering a specific feature which needs a permission which is now removed. If this ever occurs, this gap in our testing would need to be fixed.
Ah btw, I like the split into two separate files!
deploy/helm/airflow-operator/templates/clusterrole-operator.yaml
Outdated
Show resolved
Hide resolved
deploy/helm/airflow-operator/templates/clusterrole-product.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Techassi <git@techassi.dev>
Techassi
previously approved these changes
Mar 27, 2026
Member
Techassi
left a comment
Techassi
left a comment
There was a problem hiding this comment.
LGTM, just two minor comments.
Co-authored-by: Techassi <git@techassi.dev>
Techassi
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stackabletech/issues#798
Note
This was initially generated by a coding assistant to see how well it can inspect code and review the RBAC rules. the changes will be properly checked before reviews are requested.
Explanation
The file
deploy/helm/airflow-operator/templates/roles.yamlwas audited. Every RBAC rule nowhas a comment explaining why it exists. The following unnecessary permissions were removed:
batch/jobs(entire rule)AirflowDBcontroller removed in PR #322. DB init now runs as part of the scheduler entrypoint. Thedelete_orphaned_resourcesframework does attempt cleanup on Jobs, but silently skips on 403, and since no Jobs are ever created there is nothing to clean up.podsfrom operator ClusterRoleendpointsupdateverb on all operator ClusterRole resourcesPATCH), neverPUT(update/replace). Confirmed by searching forclient.update()calls — none exist.watchon rolebindings, poddisruptionbudgets, listeners.owns()or.watches()call). They only need verbs for SSA (create+patch) and orphan cleanup (list+delete), plusgetfor theReconciliationPausedpath.patchon the primary CRD (airflowclusters)airflowclusters/status(separate rule), never the main resource itself. The controller only needsget+list+watchon the main CRD.getonconfigmaps,secrets,serviceaccountsfor the product ClusterRolelistandwatchonnodes